FR-6422: Add start-first-deployments flags in create app and environment commands - #2
Merged
pheeque1 merged 1 commit intoAug 31, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating an app or environment now needs clear docs and tests for whether the first deployment starts right away. Without this, users can miss which flags are required to deploy during creation.
Solution
Document
--deployforapps createandenvironments create, including the Git flags each command needs. Update the environment create command test so it verifies the request sendsdeployment.git.branchanddeployment.startFirstDeploymentwhen--branchand--deployare used.Testing:
internal/cmd/root/root_test.gowas updated to cover the environment create deploy payload.